You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/24 02:25:50 UTC
[GitHub] [commons-csv] dota17 commented on a change in pull request #62: Fix
the old test case record.getComment() will never be null
dota17 commented on a change in pull request #62: Fix the old test case record.getComment() will never be null
URL: https://github.com/apache/commons-csv/pull/62#discussion_r396867943
##########
File path: src/test/java/org/apache/commons/csv/CSVFileParserTest.java
##########
@@ -93,11 +93,8 @@ public void testCSVFile(final File testFile) throws Exception {
try (final CSVParser parser = CSVParser.parse(new File(BASE, split[0]), Charset.defaultCharset(), format)) {
for (final CSVRecord record : parser) {
String parsed = Arrays.toString(record.values());
- if (checkComments) {
- final String comment = record.getComment().replace("\n", "\\n");
- if (comment != null) {
Review comment:
thanks for review , I have fix that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services