You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2023/06/05 15:07:59 UTC
[GitHub] [ignite-3] zstan opened a new pull request, #2145: IGNITE-19493 Sql. Change query execution flow.
zstan opened a new pull request, #2145:
URL: https://github.com/apache/ignite-3/pull/2145
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2145: IGNITE-19493 Sql. Change query execution flow.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2145:
URL: https://github.com/apache/ignite-3/pull/2145#discussion_r1219184429
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java:
##########
@@ -148,18 +150,19 @@ public SqlSchemaManagerImpl(
/** {@inheritDoc} */
@Override
- public SchemaPlus schema(@Nullable String schema) {
+ public SchemaPlus schema(@Nullable String schema, HybridTimestamp ts) {
+ Objects.requireNonNull(ts, "timestamp");
SchemaPlus schemaPlus = calciteSchemaVv.latest();
// stub for waiting pk indexes, more clear place is IgniteSchema
CompletableFuture.allOf(pkIdxReady.values().toArray(CompletableFuture[]::new)).join();
- return schema != null ? schemaPlus.getSubSchema(schema) : schemaPlus.getSubSchema(DEFAULT_SCHEMA_NAME);
+ return getSchemaOrDefault(schema, schemaPlus);
Review Comment:
```suggestion
return schemaPlus.getSubSchema(Objects.requireNonNullOrElse(schema, DEFAULT_SCHEMA_NAME));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2145: IGNITE-19493 Sql. Change query execution flow.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2145:
URL: https://github.com/apache/ignite-3/pull/2145#discussion_r1219198850
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManager.java:
##########
@@ -27,8 +28,11 @@
public interface SqlSchemaManager {
/**
* Returns a required schema if specified, or default schema otherwise.
+ *
+ * @param schema Schema name.
+ * @param ts Transaction timestamp to obtain the effective schema version.
*/
- SchemaPlus schema(@Nullable String schema);
+ SchemaPlus schema(@Nullable String schema, HybridTimestamp ts);
Review Comment:
https://github.com/apache/ignite-3/pull/2100/files#diff-93ec945a50393605375cb8053d980c3c916aa31bfe6e2479c7c02b459aa2f3e7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2145: IGNITE-19493 Sql. Change query execution flow.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2145:
URL: https://github.com/apache/ignite-3/pull/2145#discussion_r1219198850
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManager.java:
##########
@@ -27,8 +28,11 @@
public interface SqlSchemaManager {
/**
* Returns a required schema if specified, or default schema otherwise.
+ *
+ * @param schema Schema name.
+ * @param ts Transaction timestamp to obtain the effective schema version.
*/
- SchemaPlus schema(@Nullable String schema);
+ SchemaPlus schema(@Nullable String schema, HybridTimestamp ts);
Review Comment:
https://github.com/apache/ignite-3/pull/2100/files#diff-553fb292f0a67df8a30b796566c1c5c42d2bb5022b353861a0cc40dd573fb6b7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2145: IGNITE-19493 Sql. Change query execution flow.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2145:
URL: https://github.com/apache/ignite-3/pull/2145#discussion_r1219180296
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManager.java:
##########
@@ -27,8 +28,11 @@
public interface SqlSchemaManager {
/**
* Returns a required schema if specified, or default schema otherwise.
+ *
+ * @param schema Schema name.
+ * @param ts Transaction timestamp to obtain the effective schema version.
*/
- SchemaPlus schema(@Nullable String schema);
+ SchemaPlus schema(@Nullable String schema, HybridTimestamp ts);
Review Comment:
AFAIK, we agree to use long timestamp HybridTimeStamp.longValue()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan closed pull request #2145: IGNITE-19493 Sql. Change query execution flow.
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan closed pull request #2145: IGNITE-19493 Sql. Change query execution flow.
URL: https://github.com/apache/ignite-3/pull/2145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org