You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "CodingCat (via GitHub)" <gi...@apache.org> on 2024/02/01 14:59:57 UTC
[PR] Fix typos in profile name when checking dependencies [incubator-celeborn]
CodingCat opened a new pull request, #2277:
URL: https://github.com/apache/incubator-celeborn/pull/2277
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
a tiny typo fix
### Why are the changes needed?
found internally that we have a non-exist profile name "server", and verified in upstream we also have this problem https://github.com/apache/incubator-celeborn/actions/runs/7721711328/job/21048669317?pr=2273
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos in profile name when checking dependencies [incubator-celeborn]
Posted by "CodingCat (via GitHub)" <gi...@apache.org>.
CodingCat commented on PR #2277:
URL: https://github.com/apache/incubator-celeborn/pull/2277#issuecomment-1921530450
@waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR]Fix typos in profile name when checking dependencies [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2277:
URL: https://github.com/apache/incubator-celeborn/pull/2277#issuecomment-1921562495
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`954277d`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/954277d07c7a87731f888058034036c9aebd84a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.11% compared to head [(`7344178`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2277?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.82%.
> Report is 11 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 48.11% 47.82% -0.29%
==========================================
Files 197 200 +3
Lines 12272 12449 +177
Branches 1071 1088 +17
==========================================
+ Hits 5904 5953 +49
- Misses 5980 6103 +123
- Partials 388 393 +5
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2277?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR]Fix typos in profile name when checking dependencies [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2277: [MINOR]Fix typos in profile name when checking dependencies
URL: https://github.com/apache/incubator-celeborn/pull/2277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org