You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/02/23 02:04:52 UTC
Re: Review Request 42687: AMBARI-14690: Configurable system resources
for ambari agents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42687/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 1:04 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
Changes
-------
added unit test
Bugs: AMBARI-14690
https://issues.apache.org/jira/browse/AMBARI-14690
Repository: ambari
Description
-------
detailed description: https://issues.apache.org/jira/browse/AMBARI-14690
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 80afdb2
ambari-agent/conf/windows/ambari-agent.ini 1b24f25
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
ambari-agent/src/main/python/ambari_agent/Facter.py 85650b9
ambari-agent/src/test/python/ambari_agent/TestHardware.py 9ab02dc
Diff: https://reviews.apache.org/r/42687/diff/
Testing (updated)
-------
mvn -pl ambari-agent clean test
Ran 424 tests in 10.708s
OK
Thanks,
Oliver Szabo
Re: Review Request 42687: AMBARI-14690: Configurable system resources
for ambari agents
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42687/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 10:28 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
Changes
-------
added pydoc
Bugs: AMBARI-14690
https://issues.apache.org/jira/browse/AMBARI-14690
Repository: ambari
Description
-------
detailed description: https://issues.apache.org/jira/browse/AMBARI-14690
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 80afdb2
ambari-agent/conf/windows/ambari-agent.ini 1b24f25
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
ambari-agent/src/main/python/ambari_agent/Facter.py 85650b9
ambari-agent/src/test/python/ambari_agent/TestHardware.py 9ab02dc
Diff: https://reviews.apache.org/r/42687/diff/
Testing
-------
mvn -pl ambari-agent clean test
Ran 424 tests in 10.708s
OK
Thanks,
Oliver Szabo
Re: Review Request 42687: AMBARI-14690: Configurable system resources
for ambari agents
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42687/#review120230
-----------------------------------------------------------
Ship it!
ambari-agent/src/main/python/ambari_agent/Facter.py (line 166)
<https://reviews.apache.org/r/42687/#comment181655>
Can you add some pydoc for this?
- Alejandro Fernandez
On Feb. 23, 2016, 1:04 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42687/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 1:04 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-14690
> https://issues.apache.org/jira/browse/AMBARI-14690
>
>
> Repository: ambari
>
>
> Description
> -------
>
> detailed description: https://issues.apache.org/jira/browse/AMBARI-14690
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 80afdb2
> ambari-agent/conf/windows/ambari-agent.ini 1b24f25
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
> ambari-agent/src/main/python/ambari_agent/Facter.py 85650b9
> ambari-agent/src/test/python/ambari_agent/TestHardware.py 9ab02dc
>
> Diff: https://reviews.apache.org/r/42687/diff/
>
>
> Testing
> -------
>
> mvn -pl ambari-agent clean test
>
> Ran 424 tests in 10.708s
>
> OK
>
>
> Thanks,
>
> Oliver Szabo
>
>