[jira] [Commented] (CASSANDRA-6655) Writing mostly deletes to a Memtable results in undercounting the table's occupancy so it may not flush

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892291#comment-13892291 ] 

Sylvain Lebresne commented on CASSANDRA-6655:
---------------------------------------------

While we're at it, we could also fix the update to currentOperations to take range tombstones into account, it doesn't particularly make sense that it's not taken into account there too (and it's currently somewhat breaking DataTacker.isEmpty()).

Nit: I'd change 'isModifiedBy' to something like 'mayModify' (which imply reversing receiver and argument) to avoid future misuse since 'isModifiedBy' only tell if it may be modified but doesn't guarantee it will. The rest lgtm.

Also probably worth committing to 1.2 (it's a proper bug and the fix is relatively simple).

For those following along at home, this only affects deletes through range tombstones (though full partition deletions were not added to the memtable size, they were accounted in currentOperations and wouldn't end up not flushing).

> Writing mostly deletes to a Memtable results in undercounting the table's occupancy so it may not flush
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6655
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6655
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 2.0.5, 2.0.6
>
>         Attachments: tmp-2.1.patch, tmp.patch
>
>
> In the extreme case of only deletes the memtable will never flush, and we will OOM.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)