[I] stats_over_http always registers a config reload continuation, even without a config file [trafficserver]

["zwoop (via GitHub)" <gi...@apache.org>]

zwoop opened a new issue, #10658:
URL: https://github.com/apache/trafficserver/issues/10658

   There's no reason, as far as I can tell, for this code if the plugin has not been given a YAML configuration (to reload).
   
   ```
     /* Create continuation for management updates to re-read config file */
     config_cont = TSContCreate(config_handler, TSMutexCreate());
     TSContDataSet(config_cont, (void *)config_holder);
     TSMgmtUpdateRegister(config_cont, PLUGIN_NAME);
   ```
   
   The easy fix here is to just not call this if there's no config file. However, with #10642, we may also want to clean up the configuration reload, such that we let the core deal with the file timestamps etc. If the file name is given to TSMgmtUpdateRegister(), that continuation will only be called if the file has actually changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] stats_over_http always registers a config reload continuation, even without a config file [trafficserver]

["ezelkow1 (via GitHub)" <gi...@apache.org>]

ezelkow1 closed issue #10658: stats_over_http always registers a config reload continuation, even without a config file
URL: https://github.com/apache/trafficserver/issues/10658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org