You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/27 11:38:17 UTC
[GitHub] [dolphinscheduler] HomminLee opened a new issue, #11680: [Improvement][UI] Improvement ui when batch delete workflow
HomminLee opened a new issue, #11680:
URL: https://github.com/apache/dolphinscheduler/issues/11680
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When batch delete workflow definition or workflow instance, there are two unfriendly questions:
1. Case of batch delete, there may a long error message here. To be more friendly, long error message returned by backend will contains newline symbol `\n`, but message prompt in UI is still one line.
```
{
"code": 50026,
"msg": "batch delete process definition by codes error: \n delete process definition [sleep_copy_20220827111607921] error: process definition [sleep_copy_20220827111607921] is already on line\n delete process definition [sleep] error: process definition [sleep] is already on line",
"data": null,
"failed": true,
"success": false
}
```
<img width="840" alt="image" src="https://user-images.githubusercontent.com/25881185/187028066-a3da5153-3300-4ae0-858c-e309f5c0f129.png">
2. Anyone of workflow delete fail on batch delete, backend will return error. Actually, other workflows are deleted successfully, and workflow table on the page has not changed, requires user to manually refresh page. So I think should refresh workflow table even if return error when batch delete workflow definition or workflow instance.
<img width="1159" alt="image" src="https://user-images.githubusercontent.com/25881185/187028479-bdcaa78a-d1bc-45cd-bf11-c0bee4d58abc.png">
link #11554
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11680: [Improvement][UI] Improvement ui when batch delete workflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11680:
URL: https://github.com/apache/dolphinscheduler/issues/11680#issuecomment-1229176299
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee commented on issue #11680: [Improvement][UI] Improvement ui when batch delete workflow
Posted by GitBox <gi...@apache.org>.
HomminLee commented on issue #11680:
URL: https://github.com/apache/dolphinscheduler/issues/11680#issuecomment-1237785120
Change the way, if any workflow fails to delete, stop and rollback. So, those problem not exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee closed issue #11680: [Improvement][UI] Improvement ui when batch delete workflow
Posted by GitBox <gi...@apache.org>.
HomminLee closed issue #11680: [Improvement][UI] Improvement ui when batch delete workflow
URL: https://github.com/apache/dolphinscheduler/issues/11680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org