You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/28 01:19:15 UTC

[GitHub] [echarts] n0099 opened a new issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

n0099 opened a new issue #15966:
URL: https://github.com/apache/echarts/issues/15966


   ### Version
   5.2.1
   
   ### Steps to reproduce
   4.9.0: https://jsfiddle.net/58yq7tmn/
   
   5.2.0: https://jsfiddle.net/58yq7tmn/1/
   
   ### What is expected?
   text font is keeping previous value after `setOption()`
   
   ### What is actually happening?
   text font is reset to default
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953425152


   It's introduced in 5.0.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 edited a comment on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 edited a comment on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953435418


   > @n0099 Sorry I understood it wrong. Use `fontSize` and `fontFamily` instead of `font` may solve the issue.
   
   It works: https://jsfiddle.net/u0n6eq92/, but why?
   But the [graphic.elements-text.style.textAlign](https://echarts.apache.org/en/option.html#graphic.elements-text.style.textAlign) was still get reset by new `setOption()`, and `style.fill` won't. Might many other prop of style is get effected by this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953424761


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
   
   You may also check out the [API](https://echarts.apache.org/api.html) and [chart option](https://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/maillist.html).
   
   Have a nice day! 🍵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 edited a comment on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 edited a comment on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953425152


   It's introduced in 5.0.0, covers 5.2.1, we can work around this by duplicate other styles while invoking `setOption()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953427504


   > See the upgrading guide in https://echarts.apache.org/handbook/en/basics/release-note/v5-upgrade-guide/#deprecated-apis
   
   it only says `Prop style.text are deprecated in elements except Text. Instead, Prop set textContent and textConfig are provided to support more powerful capabilities.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 edited a comment on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 edited a comment on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953435418


   > @n0099 Sorry I understood it wrong. Use `fontSize` and `fontFamily` instead of `font` may solve the issue.
   
   It works: https://jsfiddle.net/u0n6eq92/, but why?
   but the [graphic.elements-text.style.textAlign](https://echarts.apache.org/en/option.html#graphic.elements-text.style.textAlign) was still get reset by new `setOption()`, might many other prop of style is get effected by this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953432395


   Yes and please use [textContent](https://echarts.apache.org/en/option.html#graphic.elements-group.textContent), [textConfig](https://echarts.apache.org/en/option.html#graphic.elements-group.textConfig) instead of text if you upgraded to v5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953437573


   Also I'm wondering how to set line height for `graphic.text`? `graphic.element.textConfig` doesn't have such related prop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953427096


   See the upgrading guide in https://echarts.apache.org/handbook/en/basics/release-note/v5-upgrade-guide/#deprecated-apis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang removed a comment on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
pissang removed a comment on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953432395


   Yes and please use [textContent](https://echarts.apache.org/en/option.html#graphic.elements-group.textContent), [textConfig](https://echarts.apache.org/en/option.html#graphic.elements-group.textConfig) instead of text if you upgraded to v5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 edited a comment on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 edited a comment on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953437573


   Also I'm wondering how to set line height for `graphic.text`? `graphic.element.textConfig` doesn't have such related prop. Setting `graphic.elements-text.style.lineWidth` haven't any changes, I don't know what's the meaning of 'stroke' in description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953433667


   @n0099 Sorry I understood it wrong. Use `fontSize` and `fontFamily` instead of `font` may solve the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] n0099 commented on issue #15966: [4->5 breaking] assign to `graphic.style.text` will reset other properties of `style`

Posted by GitBox <gi...@apache.org>.
n0099 commented on issue #15966:
URL: https://github.com/apache/echarts/issues/15966#issuecomment-953435418


   > @n0099 Sorry I understood it wrong. Use `fontSize` and `fontFamily` instead of `font` may solve the issue.
   
   It works: https://jsfiddle.net/u0n6eq92/, but why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org