You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/09 08:34:25 UTC

[GitHub] [spark] MaxGekk commented on pull request #35756: [SPARK-38437][SQL] Lenient serialization of datetime from datasource

MaxGekk commented on pull request #35756:
URL: https://github.com/apache/spark/pull/35756#issuecomment-1062675605


   > ... the per record `instanceof` should have nearly 0 overhead ...
   
   The datetime ops are pretty expensive, especially when need to look up to history data to calculate time zone offsets. Such op could take milliseconds comparing to `instanceof` which takes a few nanoseconds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org