You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by sayap <gi...@git.apache.org> on 2017/08/28 10:16:14 UTC

[GitHub] libcloud pull request #1095: Need to call `page` when using `GCEList` for pa...

GitHub user sayap opened a pull request:

    https://github.com/apache/libcloud/pull/1095

    Need to call `page` when using `GCEList` for pagination to work

    Otherwise, the `if self.gce_params:` condition will evaluate to false as the dict remains empty.
    
    This is a follow-up fix to https://github.com/apache/libcloud/pull/939

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KMK-ONLINE/libcloud gce-500-images

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1095.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1095
    
----
commit f2395f361ae08b080f5e5daa3996de6456310056
Author: Yap Sok Ann <so...@gmail.com>
Date:   2017-06-15T09:07:54Z

    Need to call `page` when using `GCEList` for pagination to work
    
    Otherwise, the `if self.gce_params:` condition will evaluate to false
    as the dict remains empty.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1095: Need to call `page` when using `GCEList` for pa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1095


---