You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/04 17:36:19 UTC

[GitHub] [pulsar] dlg99 commented on pull request #10480: [Broker] Fix race condition in invalidating ledger cache entries

dlg99 commented on pull request #10480:
URL: https://github.com/apache/pulsar/pull/10480#issuecomment-832119059


   @lhotari I agree with @merlimat on " If the issue is that we're using an already released buffer, we should fix that instead."
   It could be caused by i.e. an implementation of the ReadEntriesCallback/ReadEntryCallback/whatever other callback that is expected to properly release entry. Or, as you mentioned at the issue, it could be https://github.com/netty/netty/issues/10986
   
   Other issue is: do we have a repro? 
   Have we confirmed that upgrade of Netty to a version with fix https://github.com/netty/netty/issues/10986 doesn't help? 
   and that this fix helps?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org