You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/22 11:29:13 UTC
Review Request 54974: Actually overloaded function from base class in
LibeventSSLSocketImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54974/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Benjamin Mahler.
Repository: mesos
Description
-------
The function `LibeventSSLSocketImpl::shutdown` was intended to
overload `process::network::internal::SocketImpl`. As implemented it
however used a different number of arguments than the base method
so did not actually overload. The signature of the base method was
changed as part of `4417a4e891`.
This change adds an unused dummy parameter allowing us to overload the
correct base method again.
Diffs
-----
3rdparty/libprocess/src/libevent_ssl_socket.hpp 57eaf4f607d0628db466cc1a139772eeeaa51136
3rdparty/libprocess/src/libevent_ssl_socket.cpp dddd0e292a8b0d470f4e199db08f09a0c863d73c
Diff: https://reviews.apache.org/r/54974/diff/
Testing
-------
`make check` (on various flavors of Linux in internal CI)
Thanks,
Benjamin Bannier
Re: Review Request 54974: Actually overloaded function from base
class in LibeventSSLSocketImpl.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54974/#review159953
-----------------------------------------------------------
See https://issues.apache.org/jira/browse/MESOS-6789 for more context. We need to change the body of the overriden `shutdown` function too.
- Joseph Wu
On Dec. 22, 2016, 3:29 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54974/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 3:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The function `LibeventSSLSocketImpl::shutdown` was intended to
> overload `process::network::internal::SocketImpl`. As implemented it
> however used a different number of arguments than the base method
> so did not actually overload. The signature of the base method was
> changed as part of `4417a4e891`.
>
> This change adds an unused dummy parameter allowing us to overload the
> correct base method again.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp 57eaf4f607d0628db466cc1a139772eeeaa51136
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp dddd0e292a8b0d470f4e199db08f09a0c863d73c
>
> Diff: https://reviews.apache.org/r/54974/diff/
>
>
> Testing
> -------
>
> `make check` (on various flavors of Linux in internal CI)
>
>
> Thanks,
>
> Benjamin Bannier
>
>