You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/07/03 07:42:27 UTC

[GitHub] storm pull request #2710: STORM-3099: Extend metrics on supervisor, workers ...

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2710#discussion_r199710919
  
    --- Diff: storm-server/src/main/java/org/apache/storm/daemon/drpc/DRPC.java ---
    @@ -208,6 +208,7 @@ public void failRequest(String id, DRPCExecutionException e) throws Authorizatio
             }
         }
     
    +    //Should this be changed to private?
    --- End diff --
    
    Leave this to the comment on PR or file an issue. TODO-like comment is tend to not be addressed afterwards.


---