You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/24 14:28:38 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #11761: Forget to release memory on message send timeout
Shoothzj opened a new pull request #11761:
URL: https://github.com/apache/pulsar/pull/11761
### Motivation
The producer doesn't release the meomry when msg send timeout
### Modifications
When the message timeout, release the memory too.
### Documentation
We don't need to update docs, because it's a bug fix.
### reproduce the problem
- start pulsar server
- start pulsar producer, which will send msg for 10 minutes(queueSize 0, memory limit 50MB)
- close the pulsar server
- wait for 10 minutes over.
Look the heapdump, it shows pendingMessages size is 0, but Memory used `52429824`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #11761: Forget to update memory usage on message send timeout
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #11761:
URL: https://github.com/apache/pulsar/pull/11761#issuecomment-905148299
> Change LGTM. It should be easy to assert the the memory size in a unit test.
>
> 1. Create producer
> 2. Stop broker
> 3. Publish with timeout
> 4. Wait until all send operations have failed
> 5. The memory controller should report usage==0
You are right. Unit test is more efficient way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 merged pull request #11761: Forget to update memory usage on message send timeout
Posted by GitBox <gi...@apache.org>.
hangc0276 merged pull request #11761:
URL: https://github.com/apache/pulsar/pull/11761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #11761: Forget to release memory on message send timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11761:
URL: https://github.com/apache/pulsar/pull/11761#issuecomment-904790585
very interesting.
can you please add some unit test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org