You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "andreachild (via GitHub)" <gi...@apache.org> on 2024/11/04 18:14:53 UTC

[PR] Update SigV4 interceptor to use latest aws sdk version [tinkerpop]

andreachild opened a new pull request, #2883:
URL: https://github.com/apache/tinkerpop/pull/2883

   Updated SigV4 interceptor to use the latest version of `software.amazon.awssdk` and removed old dependency on `aws-java-sdk-core`. Since latest version of `SignedRequest` has headers that support multiple values for the same header via Map<String,List> I added validation checks that the expected signed headers only have 1 value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update SigV4 interceptor to use latest aws sdk version [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #2883:
URL: https://github.com/apache/tinkerpop/pull/2883#issuecomment-2455503913

   Closing in favour of https://github.com/apache/tinkerpop/pull/2884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update SigV4 interceptor to use latest aws sdk version [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild closed pull request #2883: Update SigV4 interceptor to use latest aws sdk version
URL: https://github.com/apache/tinkerpop/pull/2883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update SigV4 interceptor to use latest aws sdk version [tinkerpop]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2883:
URL: https://github.com/apache/tinkerpop/pull/2883#issuecomment-2455463284

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `86.95652%` with `6 lines` in your changes missing coverage. Please review.
   > Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`master-http@57c25d2`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/tinkerpop/pull/2883?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/tinkerpop/gremlin/driver/auth/Sigv4.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2883?src=pr&el=tree&filepath=gremlin-driver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fdriver%2Fauth%2FSigv4.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9hdXRoL1NpZ3Y0LmphdmE=) | 86.95% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff               @@
   ##             master-http    #2883   +/-   ##
   ==============================================
     Coverage               ?   77.79%           
     Complexity             ?    13537           
   ==============================================
     Files                  ?     1015           
     Lines                  ?    59238           
     Branches               ?     6806           
   ==============================================
     Hits                   ?    46083           
     Misses                 ?    10851           
     Partials               ?     2304           
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2883?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org