You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2019/10/06 11:07:21 UTC
[Bug 63809] New: Upgrade Commons Collections and DBCP2
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
Bug ID: 63809
Summary: Upgrade Commons Collections and DBCP2
Product: JMeter
Version: 5.2
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: orimarko@gmail.com
Target Milestone: JMETER_5.2
Upgrade Commons Collections to version 4.4.0
Upgrade Commons DBCP2 to version 2.7.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Status|NEW |NEEDINFO
--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Thanks for the hint orimarko.
The update to commons-collections4 is a bit more involved than the update of
commons-dbcp2. I have opened a PR https://github.com/apache/jmeter/pull/557
which you might want to check.
commit fee5548860f8dfe806a466dc0d90ffdb8a2570f4
Author: Felix Schumacher <fe...@internetallee.de>
AuthorDate: Sun Feb 16 14:08:46 2020 +0100
Updated commons-dbcp2 to 2.7.0 (from 2.5.0)
Bugzilla Id: 63809
---
gradle.properties | 2 +-
xdocs/changes.xml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
--- Comment #4 from orimarko <or...@gmail.com> ---
We can use your Pull request instead, Main difference is that I changed
CircularFifoQueue to ArrayBlockingQueue as suggested in
https://issues.apache.org/jira/browse/COLLECTIONS-432, but it also decided to
keep CircularFifoQueue in collections4
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Felix Schumacher <fe...@internetallee.de> ---
Yes, we are on dbcp2 2.9.0 and commons-collections4 4.4
We are waiting for your feedback ;)
But as we already did one round of RC for JMeter 5.5, I think it is safe to
close this issue as fixed.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
Thanks for the patch, can you comment on the places, where your patch differs
from the pull request https://github.com/apache/jmeter/pull/557 from comment 1?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
Target Milestone|JMETER_5.2 |---
OS| |All
Severity|normal |enhancement
Hardware|PC |All
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
orimarko <or...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
--- Comment #6 from orimarko <or...@gmail.com> ---
DBCP2 already updated to 2.9.0, have your commit already merged ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
orimarko <or...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orimarko@gmail.com
--- Comment #2 from orimarko <or...@gmail.com> ---
Created attachment 37312
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37312&action=edit
Patch for upgrade collections
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63809] Upgrade Commons Collections and DBCP2
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63809
--- Comment #5 from Felix Schumacher <fe...@internetallee.de> ---
Thanks for the patch, I used my old patch, as I think the ArrayBlockingQueue
would not have worked as a replacement in our case, where we don't want
blocking behaviour (at least in some cases :))
It would be great, if you could test the next builds and report back, whether
it works for you.
commit 28fce6057c72d32aa71f7437d18abb7c28ffc62f
AuthorDate: Sun Feb 16 15:30:39 2020 +0100
Updated commons-collections to 4.4 (from 3.2.2)
Keep old commons-collections 3.x for compatibility
Bugzilla Id: 63809
Closes #557 on github
---
checksum.xml | 2 ++
gradle.properties | 1 +
src/bom/build.gradle.kts | 1 +
src/components/build.gradle.kts | 2 +-
.../visualizers/ViewResultsFullVisualizer.java | 22 ++++++++++------------
src/core/build.gradle.kts | 5 ++++-
.../java/org/apache/jmeter/gui/LoggerPanel.java | 19 +++++++++----------
.../org/apache/jmeter/save/CSVSaveService.java | 6 +++---
.../org/apache/jmeter/services/FileServer.java | 8 ++++----
.../apache/jmeter/testbeans/gui/TestBeanGUI.java | 18 ++++++++----------
.../org/apache/jmeter/util/JSR223TestElement.java | 7 +++----
src/dist/build.gradle.kts | 2 +-
src/jorphan/build.gradle.kts | 2 +-
.../java/org/apache/jorphan/util/XMLBuffer.java | 8 ++++----
src/protocol/build.gradle.kts | 2 +-
.../jmeter/protocol/http/control/CacheManager.java | 7 +++----
.../jmeter/protocol/http/parser/TestCssParser.java | 14 +++++++-------
xdocs/changes.xml | 1 +
18 files changed, 64 insertions(+), 63 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.