You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2016/02/25 08:48:46 UTC
[2/3] mina-sshd git commit: [SSHD-646] ThreadGroup created in
ThreadUtils is not destroyed and causes memory leak
[SSHD-646] ThreadGroup created in ThreadUtils is not destroyed and causes memory leak
Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/abc4c822
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/abc4c822
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/abc4c822
Branch: refs/heads/1.1.1
Commit: abc4c8227dda0af3eae077ba9be5578b66d629c4
Parents: b85a9f3
Author: Lyor Goldstein <ly...@gmail.com>
Authored: Thu Feb 25 09:49:11 2016 +0200
Committer: Lyor Goldstein <ly...@gmail.com>
Committed: Thu Feb 25 09:49:11 2016 +0200
----------------------------------------------------------------------
.../java/org/apache/sshd/common/util/threads/ThreadUtils.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/abc4c822/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java b/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
index d0a25ed..9008635 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
@@ -163,9 +163,8 @@ public final class ThreadUtils {
public SshdThreadFactory(String name) {
SecurityManager s = System.getSecurityManager();
- ThreadGroup parentGroup = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
+ group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
String effectiveName = name.replace(' ', '-');
- group = new ThreadGroup(parentGroup, "sshd-" + effectiveName + "-group");
namePrefix = "sshd-" + effectiveName + "-thread-";
}