You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/13 22:05:37 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.
URL: https://github.com/apache/airflow/pull/5550#discussion_r303220308
 
 

 ##########
 File path: tests/contrib/hooks/test_emr_hook.py
 ##########
 @@ -62,7 +62,7 @@ def test_create_job_flow_extra_args(self):
         # coverage of EMR isn't 100% it turns out.
         cluster = hook.create_job_flow({'Name': 'test_cluster',
                                         'ReleaseLabel': '',
-                                        'AmiVersion': '3.2'})
+                                        'AmiVersion': '3.2', 'Instances': {'TerminationProtected': True}})
 
 Review comment:
   Could you extend the tests here to make sure that we are actually getting a merge here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services