[jira] [Created] (ARTEMIS-2272) Suspicious call `queueMap.get(ref.getQueue())` in RefsOperation.java

["Jiri Daněk (JIRA)" <ji...@apache.org>]

Jiri Daněk created ARTEMIS-2272:
-----------------------------------

             Summary: Suspicious call `queueMap.get(ref.getQueue())` in RefsOperation.java
                 Key: ARTEMIS-2272
                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2272
             Project: ActiveMQ Artemis
          Issue Type: Bug
          Components: Broker
    Affects Versions: 1.6.0
            Reporter: Jiri Daněk


{code:java}
   protected void rollbackRedelivery(Transaction tx, MessageReference ref, long timeBase, Map<QueueImpl, LinkedList<MessageReference>> queueMap) throws Exception {
      // if ignore redelivery check, we just perform redelivery straight
      if (ref.getQueue().checkRedelivery(ref, timeBase, ignoreRedeliveryCheck)) {
         LinkedList<MessageReference> toCancel = queueMap.get(ref.getQueue());
{code}

I am thinking that probably {{queueMap.get(ref);}} is the correct call, judging by the types of the objects involved.

This is from an IntelliJ warning "Suspicious call to 'Map.get' less... (Ctrl+1) 
Inspection info: Reports method calls to parameterized collections, where actual argument type does not correspond to the collection's elements type."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)