You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 12:44:36 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

xhochy commented on a change in pull request #8878:
URL: https://github.com/apache/arrow/pull/8878#discussion_r555743088



##########
File path: python/requirements-wheel-test.txt
##########
@@ -1,10 +1,7 @@
 cffi
 cython
 hypothesis
-numpy==1.14.5; python_version < "3.7"
-numpy==1.16.0; python_version == "3.7"
-numpy==1.17.3; python_version == "3.8"
-numpy==1.19.3; python_version >= "3.9"
+numpy==1.19.4

Review comment:
       We should test with the `numpy` release we have built with and a much newer one to detect issues. Currently we only test with one and there I would prefer to test with a newer release as this has a higher chance to fail on the C-API level like we have seen with the 1.20 release candidate.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org