You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fantiq (via GitHub)" <gi...@apache.org> on 2025/08/07 05:48:33 UTC
[I] [Feature] Enable the ConfigCenter And MetadataCenter to support option of `check=false` [dubbo]
fantiq opened a new issue, #15623:
URL: https://github.com/apache/dubbo/issues/15623
### Pre-check
- [x] I am sure that all the content I provide is in English.
### Search before asking
- [x] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Descriptions
Both the ConfigCenter and the MetadataCenter support option `check`. When the initial connection attempt fails, `true` means interrupt the whole process once it fails, but `false` is not fully supported.
Overall, I believe the following points need to be supported here:
1. When the initial connection attempt fails, the whole process will not interrupted
2. When the connection recovery, some related functions also need to be recovered and supported
## ConfigCenter
- Add `boolean isAvailable()` method to `DynamicConfiguration`, used for fail fast before connection recovery.
- Once the ConfigCenter completes initialization, it will update the config items `ExternalConfig` and `AppExternalConfig`. Do we need to update these config items after the connection is recovered? Some discussions are needed.
- In the process of service export and reference, every service will create a listener for every ConfigCenter. There should recreate listener after the connection is recovered. Also the Router Rule listener need to be recreated.
- A listener is created when the `MigrationRuleListener` is initialized. Recovery also need to be supported here.
## MetadataCenter
- Add `boolean isAvailable()` method to `MetadataReport`, used for fail fast before connection recovery.
- When reporting `ServiceDefinition`, each `MetadataReport` will be traversed for reporting, and there will be failure retries. However, if all reports fail, some logging should be required.
- When reporting `ServiceNameMapping`, it will retry if all `MetadataReport` report fail, but there is a lack of retry for each `MetadataReport`.
- In the `ServiceDiscovery`, it is necessary to support both `MetadataInfo` and `ServiceInstance` reporting retries. Maybe a status for whether it has been reported or not needs to be introduced here.
## Something else
SPI extensions should support the method `boolean isAvailable()`.
### Related issues
This issue is a continuation of #15271 and it is part of PR #15594 .
### Are you willing to submit a pull request to fix on your own?
- [x] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Enable the ConfigCenter And MetadataCenter to support option of `check=false` [dubbo]
Posted by "huangqy17 (via GitHub)" <gi...@apache.org>.
huangqy17 commented on issue #15623:
URL: https://github.com/apache/dubbo/issues/15623#issuecomment-4213350280
Hasn't this code been reviewed yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org