You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dejan2609 (via GitHub)" <gi...@apache.org> on 2026/01/29 19:51:25 UTC
[PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
dejan2609 opened a new pull request, #21373:
URL: https://github.com/apache/kafka/pull/21373
Related link: https://docs.gradle.org/9.3.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
JIRA ticket: KAFKA-20103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-4059391452
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5203134588
Rebased onto trunk (Gradle version changed from 9.4.1 to 9.6.1) and did some basic testing locally:
- distribution created: `./gradlew rTG`
- scenario described here: https://kafka.apache.org/quickstart works as expected :white_check_mark:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "Shivamrut (via GitHub)" <gi...@apache.org>.
Shivamrut commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5114466432
Hi @dejan2609 I verified it locally and your changes fix `propName/value` syntax related warnings as expected.
I think you should merge this now as its a small mechanical change with no real risk, and waiting for Gradle 10 would just delay work that’s already done. Please correct me if Im wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-4301665899
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5115953946
I see your point @Shivamrut, we could include this change into trunk now; however, deprecated `propName/value` syntax still could be used afterwards (until Gradle major version switches from 9 to 10, that is).
All-in-all, the question stays: should we merge it now or later ?
This is up to the owners/maintainers/committers to decide (I can't do it on my own, I am just a contributor).
@mimaison, @chia7712, @clolov: please squeeze some time and have your say :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5066039523
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "Shivamrut (via GitHub)" <gi...@apache.org>.
Shivamrut commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5109008686
Hi @dejan2609 I noticed this is still in draft and marked stale. I’d be happy to help get this PR completed/merged. Rebase on latest trunk, run ./gradlew releaseTarGz with --warning-mode all, and mark ready for review if you’re busy. Just offering to collaborate.
CC - @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-3875187848
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (to comply with Gradle 10 requirements) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5264667673
Thank you @mimaison ! 🤝
You may want to check other PR's created by me (one of them is particularly interesting because it cuts build time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-3857812985
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5110258972
Hi @Shivamrut ! Solution is actually working as expected (and I just rebased it onto trunk without a single conflict :slightly_smiling_face:) but the real question is: should we try to merge in now or just before (during ?) Gradle major version upgrade from 9 to 10 ?
_Prologue (why we need to do this at some point):_ https://docs.gradle.org/9.4.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
> These generated methods are now deprecated and will be removed in Gradle 10, and both propertyName value and propertyName(value) will stop working unless the explicit method propertyName is defined. **_Use explicit assignment propertyName = value instead._**
### Test procedure:
1. Current trunk state problem report after `./gradlew clean rTG` execution - `propName/value` syntax related warnings are shown :warning::
<img width="1342" height="724" alt="image" src="https://github.com/user-attachments/assets/6066cd93-dc69-4c8c-9e76-c01bb7bfa4c5" />
2. This PR state problem report after `./gradlew clean rTG` execution - `propName/value` syntax related warnings are gone :white_check_mark::
<img width="908" height="518" alt="image" src="https://github.com/user-attachments/assets/d5c83c93-c833-4b9f-a492-0454beffbf41" />
What is your take on this @chia7712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-3819954284
FYI @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5041907655
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (to comply with Gradle 10 requirements) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5256543202
Thanks @mimaison ! I have shorten title to comply with PR checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-4290680891
Demoting to a draft for a few days (weeks) until I get some time to doublecheck it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (to comply with Gradle 10 requirements) [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #21373:
URL: https://github.com/apache/kafka/pull/21373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20103 properties value assignment syntax changed to 'propName = value' (in order to comply with future requirements announced for Gradle 10) [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21373:
URL: https://github.com/apache/kafka/pull/21373#issuecomment-5126300003
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org