[GitHub] [submarine] cdmikechen opened a new pull request #855: SUBMARINE-1124 Add the status of NOT_FOUND to replace the delete operation

[GitBox <gi...@apache.org>]

cdmikechen opened a new pull request #855:
URL: https://github.com/apache/submarine/pull/855


   ### What is this PR for?
   Submarine delete notebook row from mysql database when k8s client can not find this related NoteBook CRD. But sometimes maybe due to timeout or API error caused by network and other reasons, it also report an error. At this time, submarine will think that the resource has been lost and forcibly delete it.
   
   This is not a perfect logic. I think the better logic is to prompt the foreground that this resource has been lost and allow the user to delete it by himself.
   
   At the same time, the logic of deletion should also be readjusted. If the resource does not exist, the program can continue to execute without throwing an exception. Otherwise, an endless loop will appear, and users cannot add or delete resources with the same name.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Add a new status NOT_FOUND
   * [x] - Modify delete logic, if resources do not exist, skip it. 
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1124
   
   ### How should this be tested?
   Right now there no new test cases.
   
   ### Screenshots (if appropriate)
   No
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? /No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #855: SUBMARINE-1124 Add the status of NOT_FOUND to replace the delete operation

[GitBox <gi...@apache.org>]

asfgit closed pull request #855:
URL: https://github.com/apache/submarine/pull/855


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org