You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/05 10:06:51 UTC
[GitHub] [doris] Henry2SS opened a new pull request, #12348: [enhancement](stream load) make stream load mem limit configurable
Henry2SS opened a new pull request, #12348:
URL: https://github.com/apache/doris/pull/12348
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #12348:
URL: https://github.com/apache/doris/pull/12348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Henry2SS commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
Henry2SS commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1240143872
> > `runtime_state.cpp` the code below should be removed and replaced with `_query_options.load_mem_limit`.
> > ```
> > int64_t RuntimeState::get_load_mem_limit() {
> > if (_query_options.__isset.load_mem_limit && _query_options.load_mem_limit > 0) {
> > return _query_options.load_mem_limit;
> > } else {
> > return _query_mem_tracker->limit();
> > }
> > }
> > ```
>
> To ensure compatibility during the upgrade process, cannot be removed now Consider recording a TODO in `runtime_state.cpp`, the code is abandoned, it can be deleted after v1.3
OK. Thx for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Henry2SS commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
Henry2SS commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1241752546
> LGTM, but please add some document for this config
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1241919619
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1239297059
`runtime_state.cpp` the code below should be removed and replaced with `_query_options.load_mem_limit`.
```
int64_t RuntimeState::get_load_mem_limit() {
if (_query_options.__isset.load_mem_limit && _query_options.load_mem_limit > 0) {
return _query_options.load_mem_limit;
} else {
return _query_mem_tracker->limit();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Henry2SS commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
Henry2SS commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1237725446
> We already had a `load_mem_limit` session variable for this purpose. I think we should use that instead of adding a new config.
the defaut value of `load_mem_limit` is `0`. And it means there is no limit. And it is mainly for `INSERT INTO` operations.
it is okay to set it to `2G` by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1240142798
> `runtime_state.cpp` the code below should be removed and replaced with `_query_options.load_mem_limit`.
>
> ```
> int64_t RuntimeState::get_load_mem_limit() {
> if (_query_options.__isset.load_mem_limit && _query_options.load_mem_limit > 0) {
> return _query_options.load_mem_limit;
> } else {
> return _query_mem_tracker->limit();
> }
> }
> ```
To ensure compatibility during the upgrade process, cannot be removed now
Consider recording a TODO in `runtime_state.cpp`, the code is abandoned, it can be deleted after v1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1236836042
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12348: [enhancement](load) make default load mem limit configurable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12348:
URL: https://github.com/apache/doris/pull/12348#issuecomment-1236836090
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org