You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/27 15:35:51 UTC
[kudu-CR] WIP [java] update lastPropagatedTimestamp and resourceMetrics
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18453
Change subject: WIP [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
WIP [java] update lastPropagatedTimestamp and resourceMetrics
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
TODO: Adding Unit Test
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/1
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#5).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/5
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18453 )
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
Patch Set 5:
(3 comments)
Thanks for your crs.
http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG@7
PS5, Line 7: update lastPropagatedTimestamp and resourceMetrics
> nit: What about 'update lastPropagatedTimestamp and resourceMetrics in gotN
Done
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java:
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@227
PS5, Line 227: // bytes_read is 0.
: // String metricName = "bytes_read";
> nit: Is this comments needed?
Done
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@229
PS5, Line 229: metricName
> nit: What about rename to 'kMetricName'?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 19 May 2022 02:42:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#2).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
TODO: Adding Unit Test
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/2
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#3).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
TODO: Adding Unit Test
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/3
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18453 )
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 19 May 2022 10:33:36 +0000
Gerrit-HasComments: No
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18453 )
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Reviewed-on: http://gerrit.cloudera.org:8080/18453
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 38 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 10
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18453 )
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
Patch Set 5:
(3 comments)
LGTM. Just a few nits.
http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18453/5//COMMIT_MSG@7
PS5, Line 7: update lastPropagatedTimestamp and resourceMetrics
nit: What about 'update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback'?
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java:
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@227
PS5, Line 227: // bytes_read is 0.
: // String metricName = "bytes_read";
nit: Is this comments needed?
http://gerrit.cloudera.org:8080/#/c/18453/5/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@229
PS5, Line 229: metricName
nit: What about rename to 'kMetricName'?
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 18 May 2022 15:24:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#7).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/7
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#4).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
TODO: Adding Unit Test
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/4
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#6).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/6
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#8).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/8
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18453
to look at the new patch set (#9).
Change subject: [java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
......................................................................
[java] update lastPropagatedTimestamp and resourceMetrics in gotNextRow callback
As Andrew Wong said in https://gerrit.cloudera.org/18420,
Client should update lastPropagatedTimestamp and resourceMetrics
when client received the second or later scan response from tserver.
Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18453/9
--
To view, visit http://gerrit.cloudera.org:8080/18453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26308754ca741276204cc95cee4f8e4a91dbf331
Gerrit-Change-Number: 18453
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>