You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/06 08:54:10 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
rkhachatryan opened a new pull request #12827:
URL: https://github.com/apache/flink/pull/12827
## What is the purpose of the change
`RecordWriter.flusherException` is updated by one thread and checked by another.
The field is deliberately non-volatile for performance reasons.
But this way exception can be never seen by the 2nd thread.
This PR adds an additional volatile field which is checked every N times.
## Verifying this change
TBD: no tests added yet
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-659328815
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #12827:
URL: https://github.com/apache/flink/pull/12827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a47aa124dba8c4badae4567bb78cbc92d4ef072f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263)
* 0f39d59075500b5bed9817cc82fc9bf2e097385d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-658711550
No,
> CI build failure unrelated: https://issues.apache.org/jira/browse/FLINK-18485
(2nd build is PENDING at the moment)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a47aa124dba8c4badae4567bb78cbc92d4ef072f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f39d59075500b5bed9817cc82fc9bf2e097385d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a47aa124dba8c4badae4567bb78cbc92d4ef072f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263)
* 0f39d59075500b5bed9817cc82fc9bf2e097385d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
}, {
"hash" : "43390e73c380909dd7538ada962c565532512c5f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4554",
"triggerID" : "43390e73c380909dd7538ada962c565532512c5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43390e73c380909dd7538ada962c565532512c5f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
}, {
"hash" : "43390e73c380909dd7538ada962c565532512c5f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4554",
"triggerID" : "43390e73c380909dd7538ada962c565532512c5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f39d59075500b5bed9817cc82fc9bf2e097385d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530)
* 43390e73c380909dd7538ada962c565532512c5f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654218055
CI build failure unrelated: https://issues.apache.org/jira/browse/FLINK-18485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654106366
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a47aa124dba8c4badae4567bb78cbc92d4ef072f (Mon Jul 06 08:56:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
}, {
"hash" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530",
"triggerID" : "0f39d59075500b5bed9817cc82fc9bf2e097385d",
"triggerType" : "PUSH"
}, {
"hash" : "43390e73c380909dd7538ada962c565532512c5f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43390e73c380909dd7538ada962c565532512c5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f39d59075500b5bed9817cc82fc9bf2e097385d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4530)
* 43390e73c380909dd7538ada962c565532512c5f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a47aa124dba8c4badae4567bb78cbc92d4ef072f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12827: [FLINK-18163][task] Add RecordWriter.volatileFlusherException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12827:
URL: https://github.com/apache/flink/pull/12827#issuecomment-654120002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263",
"triggerID" : "a47aa124dba8c4badae4567bb78cbc92d4ef072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a47aa124dba8c4badae4567bb78cbc92d4ef072f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4263)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org