You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/08/01 03:18:02 UTC

Re: Review Request 71172: Looked up parent's IP for the non-checkpointed nested containers.


> On July 31, 2019, 9:15 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 1448-1461 (patched)
> > <https://reviews.apache.org/r/71172/diff/1/?file=2158035#file2158035line1448>
> >
> >     if a nested container has its own network namespace, I guess its INFO will be checkpointed?

Yes!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71172/#review216976
-----------------------------------------------------------


On July 29, 2019, 4:40 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71172/
> -----------------------------------------------------------
> 
> (Updated July 29, 2019, 4:40 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9868
>     https://issues.apache.org/jira/browse/MESOS-9868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Looked up parent's IP for the non-checkpointed nested containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f2989cf7a2161154bb7d9bf2112bee8dd3cc5cf5 
> 
> 
> Diff: https://reviews.apache.org/r/71172/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>