You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jp0317 (via GitHub)" <gi...@apache.org> on 2023/12/20 06:56:13 UTC
[PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
jp0317 opened a new pull request, #10374:
URL: https://github.com/apache/hudi/pull/10374
### Change Logs
The [PR](https://github.com/apache/hudi/pull/9482) added a table schema update step for bigquery sync tool. It seems there're two issues:
1. When it reform the schema which is then compared to the bq table schema, the reformed schema puts partition fields in the beginning, while the bq table schema by default has partition fields at the end. So it unnecessarily triggers a schema update due to to order difference.
2. Though the sync tool for 0.14.0 does not support big lake connection id (there's a recent PR last month adding this support), a user can still recreate their table manually by adding connection id. The table update is adding the new schema into. external table definition. This does not work for biglake tables, and will cause error: "Schema can be specified only on the Table.Schema field for external tables with an associated connection_id but schema was provided on Table.Externaldataconfig.Schema".
### Impact
Avoid the unnecessary table update.
### Risk level (write none, low medium or high below)
low. It only corrects the order of fields.
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #10374:
URL: https://github.com/apache/hudi/pull/10374#issuecomment-1864505008
LGTM! Thanks for catching this @jp0317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10374:
URL: https://github.com/apache/hudi/pull/10374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10374:
URL: https://github.com/apache/hudi/pull/10374#issuecomment-1863968118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21611",
"triggerID" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d4608d2bc59a13853184d887de2e894af5b02be Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21611)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10374:
URL: https://github.com/apache/hudi/pull/10374#issuecomment-1864033263
cc @the-other-tim-brown Looks a reasonable fix~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10374:
URL: https://github.com/apache/hudi/pull/10374#issuecomment-1863960259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d4608d2bc59a13853184d887de2e894af5b02be UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7242] Avoid unnecessary bigquery table update when using sync tool [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10374:
URL: https://github.com/apache/hudi/pull/10374#issuecomment-1864206455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21611",
"triggerID" : "5d4608d2bc59a13853184d887de2e894af5b02be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d4608d2bc59a13853184d887de2e894af5b02be Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21611)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org