[GitHub] [netbeans] JaroslavTulach edited a comment on pull request #2835: Opt-in and treat warnings are errors

[GitBox <gi...@apache.org>]

JaroslavTulach edited a comment on pull request #2835:
URL: https://github.com/apache/netbeans/pull/2835#issuecomment-808880242


   Now, when I run `ant -f platform/api.annotations.common build` I get a [SigTest](http://github.com/jtulach/netbeans-apitest) failure:
   ```
   Class javax.annotation.Nonnull
     "E2.8 - Removing default value from member of annotation type" : method public abstract !hasdefault javax.annotation.meta.When javax.annotation.Nonnull.when()
   Class javax.annotation.meta.TypeQualifier
     "E1.2 - API type removed" : CLASS public abstract interface !annotation javax.annotation.meta.TypeQualifier
    anno 0 java.lang.annotation.Documented()
    anno 0 java.lang.annotation.Retention(java.lang.annotation.RetentionPolicy value=RUNTIME)
    anno 0 java.lang.annotation.Target(java.lang.annotation.ElementType[] value=[ANNOTATION_TYPE])
   ```
   Looks like I haven't recreated the API properly. Let's fix that now! With 4f644ae the sigtest failures are gone - e.g. the emulation of JSR-305 is good enough from [SigTest](http://github.com/jtulach/netbeans-apitest) perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists