You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/31 21:54:15 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1160: Problem matcher

patacongo commented on a change in pull request #1160:
URL: https://github.com/apache/incubator-nuttx/pull/1160#discussion_r432987947



##########
File path: include/nuttx/arch.h
##########
@@ -100,6 +100,7 @@ typedef CODE void (*phy_enable_t)(bool enable);
  * Public Data
  ****************************************************************************/
 
+int build_breaker = broke;

Review comment:
       Why is there a global variable (not an extern prototype) in a core OS header file?  Why is there any change to a core OS header file?  This is not right.  This must be avoided.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org