[GitHub] [tvm] ekalda commented on a change in pull request #10214: [cleanup] Log compile errors for AOT tests

[GitBox <gi...@apache.org>]

ekalda commented on a change in pull request #10214:
URL: https://github.com/apache/tvm/pull/10214#discussion_r811034393



##########
File path: tests/python/relay/aot/aot_test_utils.py
##########
@@ -244,14 +244,20 @@ def parametrize_aot_options(test):
     )(test)
 
 
-def subprocess_log_output(cmd, cwd, logfile):
+def subprocess_check_log_output(cmd, cwd, logfile):
     """
     This method runs a process and logs the output to both a log file and stdout
     """
     _LOG.info("Execute (%s): %s", cwd, cmd)
     cmd_base = cmd[0] if isinstance(cmd, (list, tuple)) else cmd.split(" ", 1)[0]
     proc = subprocess.Popen(
-        cmd, cwd=cwd, shell=True, bufsize=0, stdout=subprocess.PIPE, stderr=subprocess.STDOUT
+        cmd,
+        cwd=cwd,
+        shell=True,
+        bufsize=0,
+        stdout=subprocess.PIPE,
+        stderr=subprocess.STDOUT,
+        encoding="utf-8",

Review comment:
       Nit: maybe add a variable for this `"utf-8"` and the other `"utf-8"`s below?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org