You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/30 16:08:56 UTC
[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #89: Excess strike-through on conversion
mikemccand opened a new issue, #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89
GitHub issue: https://github.com/mocobeta/forks-migration-test/issues/7230
Jira issue: https://issues.apache.org/jira/browse/LUCENE-7260
Towards the end of the opening description in GitHub there is this text:
```
For Lucene 3.6.2, the timings settle down to 200300 with the fastest being 207.
For Lucene 5.4.1, the timings settle down to 2000030000 with the fastest being 22444.
```
But it has large strike-through section that the original Jira does not have.
I think it is because `~` is being interpreted as MarkDown and is not escaped on migration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1200397024
OK I confirmed that we can just escape the `~` with a backslash:
Broken (copied from the Jira issue):
For Lucene 3.6.2, the timings settle down to 200~300 with the fastest being 207.
For Lucene 5.4.1, the timings settle down to 20000~30000 with the fastest being 22444.
Fixed:
For Lucene 3.6.2, the timings settle down to 200\~300 with the fastest being 207.
For Lucene 5.4.1, the timings settle down to 20000\~30000 with the fastest being 22444.
But we must do this after remapping accounts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1202747376
I found this is trickier than it looks...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1203992440
The difficulty here is that `~` actually has special meanings in both Jira syntax and Markdown.
The conversion process is done as follows and the order is important.
1. Convert Jira syntax to Markdown
2. Convert Jira mentions to GitHub mentions
Escaping `~` should be done _before_ 1) syntax conversion; otherwise valid strike-throughs in Markdown are affected. However, it also should be done _after_ 2) mention conversion; otherwise `[~username]` mentions are affected.
We could find a tricky workaround, but I'm afraid any workaround has unpredictable side effects - I would leave this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta closed issue #89: Excess strike-through on conversion
URL: https://github.com/apache/lucene-jira-archive/issues/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1204100796
No, in fact, it should be safely done - #108.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1207140001
Fixed in #108.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #89:
URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1200399822
I know which code we should change - will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org