[GitHub] [calcite] zabetak commented on a change in pull request #2449: [CALCITE-3745] Integrate to new version of Janino (3.1.6) to provide class loader.

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #2449:
URL: https://github.com/apache/calcite/pull/2449#discussion_r679014233



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableInterpretable.java
##########
@@ -135,7 +135,8 @@ static Bindable getBindable(ClassDeclaration expr, String s, int fieldCount)
       throws CompileException, IOException, ExecutionException {
     ICompilerFactory compilerFactory;
     try {
-      compilerFactory = CompilerFactoryFactory.getDefaultCompilerFactory();
+      compilerFactory = CompilerFactoryFactory.getDefaultCompilerFactory(

Review comment:
       Why do we need to pass explicitly the class loader of the class? Is this change necessary due to the Janino update or we are trying to tackle another problem at the same time?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org