You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2026/01/16 11:15:48 UTC

[PR] GH-3593: Remove SpatialIndexV1 [jena]

afs opened a new pull request, #3703:
URL: https://github.com/apache/jena/pull/3703

   GitHub issue resolved #3593
   
   Pull request Description:
   
   This is an attempt to remove SpatialIndexV1 by deleting the class and seeing what the consequences are.
   
   * `SpatialIndexStorage`- deprecated but not marked for removal. Reading the java comments, look like this should go.
   * `SpatialIndexIo` - this is marked for removal but should it be retained with pass-through to `SpatialIndexIoKryo.load`
   * `testSerdeSpatialIndex2` - it is only the last part of the test to remove?
   
   ----
   
    - [ ] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
    - [ ] Commits have been squashed to remove intermediate development commit messages.
    - [ ] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-3593: Remove SpatialIndexV1 [jena]

Posted by "Aklakan (via GitHub)" <gi...@apache.org>.
Aklakan commented on code in PR #3703:
URL: https://github.com/apache/jena/pull/3703#discussion_r2716645917


##########
jena-geosparql/src/main/java/org/apache/jena/geosparql/spatial/index/compat/SpatialIndexIo.java:
##########
@@ -43,27 +41,13 @@ public static final SpatialIndex load(Path spatialIndexFile) throws SpatialIndex
      * Attempt to load a spatial index from file using all supported formats.
      * This method should only be used for testing as it allows suppressing warnings when loading legacy index formats.
      */
-    public static final SpatialIndex load(Path spatialIndexFile, boolean suppressLegacyWarnings) throws SpatialIndexException {
+    private static final SpatialIndex load(Path spatialIndexFile, boolean suppressLegacyWarnings) throws SpatialIndexException {

Review Comment:
   You could remove the private load method and change the body of the public one to:
   
   ```java
   public static final SpatialIndex load(Path spatialIndexFile) throws SpatialIndexException {
       return SpatialIndexIoKryo.load(spatialIndexFile);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-3593: Remove SpatialIndexV1 [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3703:
URL: https://github.com/apache/jena/pull/3703#issuecomment-3759560378

   Currently a "draft pull request". It needs further tidying e.g commented out code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-3593: Remove SpatialIndexV1 [jena]

Posted by "Aklakan (via GitHub)" <gi...@apache.org>.
Aklakan commented on PR #3703:
URL: https://github.com/apache/jena/pull/3703#issuecomment-3784664859

   > Aside from needing some tidying up, is this what is needed for Jena6 to retire SpatialIndexV1?
   
   I'd say it looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-3593: Remove SpatialIndexV1 [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #3703:
URL: https://github.com/apache/jena/pull/3703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-3593: Remove SpatialIndexV1 [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3703:
URL: https://github.com/apache/jena/pull/3703#issuecomment-3777086663

   @Aklakan , @SimonBin 
   
   Aside from needing some tidying up, is this what is needed for Jena6 to retire `SpatialIndexV1`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org