You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by Eiliries <gi...@git.apache.org> on 2016/12/25 13:05:44 UTC
[GitHub] incubator-fineract pull request #266: Fix to charge fees when total amount c...
GitHub user Eiliries opened a pull request:
https://github.com/apache/incubator-fineract/pull/266
Fix to charge fees when total amount changed during approval.
The issue is currently at https://github.com/openMF/community-app/issues/1719 but the problem was in Fineract instead of the community-app.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Eiliries/incubator-fineract working
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit 6b2b250545d51e9ba6e61e86f36b5c3c8473d7c2
Author: Tan Gemicioglu <ta...@hotmail.com>
Date: 2016-12-25T12:54:23Z
Added charge recalculation to approval.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #266: Fix to charge fees when total amount changed ...
Posted by Eiliries <gi...@git.apache.org>.
Github user Eiliries commented on the issue:
https://github.com/apache/incubator-fineract/pull/266
@nazeer1100126 I've changed it so that it's called once and it works without any problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #266: Fix to charge fees when total amount changed ...
Posted by Eiliries <gi...@git.apache.org>.
Github user Eiliries commented on the issue:
https://github.com/apache/incubator-fineract/pull/266
Would it be a better alternative to put it between the multi disbursement and approved loan amount blocks? It would run every time the approve loan function is called but it would run once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #266: Fix to charge fees when total amount changed ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/266
@Eiliries Yes it is good to moving existing call from multidisbursement if condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #266: Fix to charge fees when total amount c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fineract/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #266: Fix to charge fees when total amount changed ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/266
If the loan is enabled with Multi disbursements, recalculateAllCharges() method will be called twice while approving a loan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---