You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tdhock (via GitHub)" <gi...@apache.org> on 2023/05/11 16:46:16 UTC
[GitHub] [arrow] tdhock opened a new pull request, #35555: increase required cmake version
tdhock opened a new pull request, #35555:
URL: https://github.com/apache/arrow/pull/35555
Current docs say that cmake >=3.5 is required to build C++ libraries, but that is not consistent with what I observe, build commands fail (do not report output similar to docs) using cmake 3.10.2 on my system, see below. Not sure what the minimal cmake version would be, but I installed cmake 3.22.1 from conda and that seems to work (gives output similar to docs).
```
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp/build(main)$ /usr/bin/cmake --version
cmake version 3.10.2
CMake suite maintained and supported by Kitware (kitware.com/cmake).
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp/build(main)$ cd ..
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp(main)$ /usr/bin/cmake --list-presets
CMake Error: The source directory "/home/tdhock/arrow-git/cpp/--list-presets" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp(main)$ /usr/bin/cmake --preset -N ninja-debug-minimal
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp(main)$ cd build
(arrow) tdhock@maude-MacBookPro:~/arrow-git/cpp/build(main)$ /usr/bin/cmake .. --preset ninja-debug-minimal
CMake Error: The source directory "/home/tdhock/arrow-git/cpp/build/ninja-debug-minimal" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #35555: increase required cmake version in C++ build docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #35555:
URL: https://github.com/apache/arrow/pull/35555#issuecomment-1549600769
Hi, thanks for the PR.
From my understanding you are trying to use presets. On the documentation it says that you can build with presets using CMake `3.21.0` or higher: https://arrow.apache.org/docs/developers/cpp/building.html#cmake-presets
You can build with `3.10.2` but you won't be able to use presets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35555: increase required cmake version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35555:
URL: https://github.com/apache/arrow/pull/35555#issuecomment-1544330251
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org