You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/28 11:35:41 UTC
[GitHub] [flink] TanYuxin-tyx opened a new pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
TanYuxin-tyx opened a new pull request #18554:
URL: https://github.com/apache/flink/pull/18554
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The read buffer allocation and output file creation of sort-shuffle is performed by the main thread. These operations are a little heavy and can block the main thread for a while which may influence other RPC calls including the follow-up task deployment. This change aims to solve the issue by moving read buffer allocation and output file creation to setup method.
## Brief change log
- *Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024804719",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024804719",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448",
"triggerID" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2aff2a86a56cc8f9a893e43f178511184a4e397f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024837817
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx removed a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx removed a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024141845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024804719
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024804719",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 2aff2a86a56cc8f9a893e43f178511184a4e397f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1029610557
@TanYuxin-tyx Thanks for the contribution. Changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1029611317
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024804719",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448",
"triggerID" : "1024837817",
"triggerType" : "MANUAL"
}, {
"hash" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448",
"triggerID" : "2aff2a86a56cc8f9a893e43f178511184a4e397f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 2aff2a86a56cc8f9a893e43f178511184a4e397f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30448)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024141845
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024137450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"triggerType" : "PUSH"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024141845",
"triggerType" : "MANUAL"
}, {
"hash" : "533bc50b38f2c9e5c755b2b77d2d0c12bd212715",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398",
"triggerID" : "1024804719",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18554:
URL: https://github.com/apache/flink/pull/18554#issuecomment-1024135364
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 533bc50b38f2c9e5c755b2b77d2d0c12bd212715 (Fri Jan 28 11:40:56 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry closed pull request #18554: [FLINK-25860][network] Move read buffer allocation and output file creation to setup method for sort-shuffle result partition to avoid blocking the main thread
Posted by GitBox <gi...@apache.org>.
wsry closed pull request #18554:
URL: https://github.com/apache/flink/pull/18554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org