You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by Kejia <gi...@git.apache.org> on 2017/05/30 15:05:43 UTC
[GitHub] climate pull request #445: optimizing traversing
GitHub user Kejia opened a pull request:
https://github.com/apache/climate/pull/445
optimizing traversing
use a set to track visiting state. also some minor updates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kejia/climate patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/445.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #445
----
commit c800e48cd2750f8fe2bbeb77750efe55c62fd05a
Author: 象道 <w....@gmail.com>
Date: 2017-05-30T14:55:31Z
optimizing traversing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #445: optimizing traversing
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/445
@Kejia can you please update this PR to resolve conflict? Thank you in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #445: optimizing traversing
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/445
@Kejia did you succesffuly run this with sample MCC-related data?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #445: optimizing traversing
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/445
I just checked and these build failures have nothing to do with the proposed patch. They are dependency related.. I assume they failed due to network issue on build machines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #445: optimizing traversing
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/445
Yeah, the failure is intermittent and OK for the time being. @kwhitehall can you try this patch out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #445: optimizing traversing
Posted by Kejia <gi...@git.apache.org>.
Github user Kejia commented on the issue:
https://github.com/apache/climate/pull/445
hi @lewismc: no, i didn't run this with sample MCC-related data. it seems the test failure is related to the package `netcdf4'. not sure about the root cause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #445: optimizing traversing
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/445
---