You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/05 04:01:21 UTC
[GitHub] [airflow] HeshamMeneisi opened a new issue, #23495: Defining custom jobs/hooks in the Helm chart would be a great feature
HeshamMeneisi opened a new issue, #23495:
URL: https://github.com/apache/airflow/issues/23495
### Description
Right now there are only two pre-defined hooks:
* `migrateDatabaseJob`
* `createUserJob`
It'd be very useful if there's an `extraJobs` section.
### Use case/motivation
Some Airflow deployments run custom CLI commands as deployment jobs. It's also very straightforward to implement this feature since we have the job template in the chart, just need to generalize it.
```
extraJobs:
- name: import-vars
command: airflow
args: ["variables", "import", "..."]
...
```
Job template:
```
{{- range .Values.extraJobs }}
[use the array element instead of .Values.jobName]
```
The same goes for the service account.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #23495: Defining custom jobs/hooks in the Helm chart would be a great feature
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23495:
URL: https://github.com/apache/airflow/issues/23495#issuecomment-1121077872
Can you do that by extending the helm-chart? I believe Helm charts can be extended by making the subcharts , so you can write your own chart with Airflow chart as a Subchart and add your jobs there.
Would that work @HeshamMeneisi ?
https://helm.sh/docs/chart_template_guide/subcharts_and_globals/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #23495: Defining custom jobs/hooks in the Helm chart would be a great feature
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #23495:
URL: https://github.com/apache/airflow/issues/23495#issuecomment-1118140362
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org