You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/02/07 13:39:15 UTC
[I] Knative dependencies are added when profile is activated [camel-k]
squakez opened a new issue, #5145:
URL: https://github.com/apache/camel-k/issues/5145
### What happened?
I am not sure if this is some regression that has slipped in in the past or it was how the original feature was designed. The fact is that I noticed that when we have the Knative resource installed, any Integration (even a simple one which does not require any Knative stuff) add all the integrations and related server is started. See this timer-2-log:
```
[1] 2024-02-07 13:30:33,706 INFO [org.apa.cam.k.Runtime] (main) Apache Camel K Runtime 3.2.3
[1] 2024-02-07 13:30:33,709 INFO [org.apa.cam.qua.cor.CamelBootstrapRecorder] (main) Bootstrap runtime: org.apache.camel.quarkus.main.CamelMainRuntime
[1] 2024-02-07 13:30:33,711 INFO [org.apa.cam.mai.MainSupport] (main) Apache Camel (Main) 4.0.2 is starting
[1] 2024-02-07 13:30:33,746 INFO [org.apa.cam.k.sup.SourcesSupport] (main) Loading routes from: SourceDefinition{name='camel-k-embedded-flow', language='yaml', type='source', location='file:/etc/camel/sources/camel-k-embedded-flow.yaml', }
[1] 2024-02-07 13:30:33,947 INFO [org.apa.cam.imp.eng.AbstractCamelContext] (main) Apache Camel 4.0.2 (camel-1) is starting
[1] 2024-02-07 13:30:33,958 INFO [org.apa.cam.imp.eng.AbstractCamelContext] (main) Routes startup (started:1)
[1] 2024-02-07 13:30:33,958 INFO [org.apa.cam.imp.eng.AbstractCamelContext] (main) Started route1 (timer://yaml)
[1] 2024-02-07 13:30:33,959 INFO [org.apa.cam.imp.eng.AbstractCamelContext] (main) Apache Camel 4.0.2 (camel-1) started in 11ms (build:0ms init:0ms start:11ms)
[1] 2024-02-07 13:30:34,066 INFO [io.quarkus] (main) camel-k-integration 2.2.0 on JVM (powered by Quarkus 3.2.9.Final) started in 1.806s. Listening on: http://0.0.0.0:8080
[1] 2024-02-07 13:30:34,067 INFO [io.quarkus] (main) Profile prod activated.
[1] 2024-02-07 13:30:34,067 INFO [io.quarkus] (main) Installed features: [camel-bean, camel-cloudevents, camel-core, camel-k-core, camel-k-runtime, camel-knative, camel-kubernetes, camel-timer, camel-yaml-dsl, cdi, kubernetes-client, smallrye-context-propagation, vertx]
```
The Integration dependency has really all the knative profile dependencies:
```
dependencies:
- camel:core
- camel:timer
- mvn:org.apache.camel.k:camel-k-knative-impl
- mvn:org.apache.camel.k:camel-k-runtime
- mvn:org.apache.camel.quarkus:camel-quarkus-knative
- mvn:org.apache.camel.quarkus:camel-quarkus-yaml-dsl
```
I have the feeling this is not correct unless any Knative feature is really used by the route.
### Steps to reproduce
_No response_
### Relevant log output
_No response_
### Camel K version
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-2018500602
Fixed in main branch, to be released in Camel K 2.3. The knative capability is only enabled when there is a knative endpoint in the route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-2014641354
I will work to enable knative trait only if there is any knative endpoint in the route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-2012360399
I remember that a few years ago, the logic was to load the knative producer or consumer extensions depending on the presence of a knative consumer/producer endpoint or in case of the trait was explicitly enabled, I don't remember if some basic bits were also added by default depending on the profile.
In my opinion, it would be better to add the dependencies only if really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j closed issue #5145: Knative dependencies are added when profile is activated
URL: https://github.com/apache/camel-k/issues/5145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-1932073729
@lburgazzoli wdyt? Is this really a regression or was the feature designed in this way for any reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-2012061342
WDYT to not set the the knative trait when the profile is knative ? Leaving it at the user discretion to enable it.
As it adds the knative dependencies to any integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Knative dependencies are added when profile is activated [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #5145:
URL: https://github.com/apache/camel-k/issues/5145#issuecomment-1932218935
The knative trait is enabled=true when in profile=knative, then the [`init` trait](https://github.com/apache/camel-k/blob/main/pkg/trait/init.go#L77) adds all dependencies from the [knative capability](https://github.com/apache/camel-k/blob/main/resources/camel-catalog-3.2.3.yaml#L77-L82).
I can't remember the reason why it's enabled by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org