You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gtxu (via GitHub)" <gi...@apache.org> on 2026/08/13 01:09:29 UTC
[PR] Fix HttpAsyncHook crash on stream/cert/trust_env connection extras [airflow]
gtxu opened a new pull request, #71524:
URL: https://github.com/apache/airflow/pull/71524
`HttpAsyncHook`/`AsyncHttpSession.run()` shares `_process_extra_options_from_connection()` with the sync `HttpHook`, but that function's output uses `requests`-flavored option names, and the async path blindly forwards all of them as kwargs into `aiohttp.ClientSession`'s request call. `aiohttp` doesn't accept `stream`, `cert`, or `trust_env` as request kwargs at all, so any HTTP connection with one of those three keys set in its `Extra` field — or passed via `extra_options=` at call time — crashed every single request with `TypeError: request() got an unexpected keyword argument '...'`. This affects both direct HttpAsyncHook usage and Airflow's deferred/async HTTP triggers, since they route through the same code path.
Separately, `check_response` (meant to suppress `raise_for_status()` on non-2xx responses, matching sync's `run_and_check()`) was accepted into the same shared dict but never actually consumed on the async side — `AsyncHttpSession.run()` always `called raise_for_status()` unconditionally, so setting `check_response: false` had no effect on async requests.
## Fix:
* `AsyncHttpSession.run()` now pops `check_response` and honors it before calling `raise_for_status()`, bringing async to parity with sync's existing behavior.
* `stream`, `cert`, and `trust_env` are filtered out before the aiohttp call, with a warning logged listing which were dropped. These three have no aiohttp equivalent worth implementing here: aiohttp streams responses by default (no `stream` flag needed), and `cert`/`trust_env` would require real work (building an `ssl.SSLContext`, restructuring session construction) that's out of scope for a crash fix.
* Corrected an existing test that had been asserting `trust_env` gets passed through to the aiohttp mock — it only passed because the plain `AsyncMock` doesn't validate kwargs against aiohttp's real method signature, which is exactly how this bug went undetected.
## Test plan:
* Added regression tests confirming `stream`/`cert`/`trust_env` never reach the aiohttp call (with the warning logged) and that `check_response: false` suppresses `raise_for_status()` on async requests.
* Full `providers-tests --test-type "Providers[http]"` suite, mypy, and ruff all pass.
Drafted-by: Claude Code (Sonnet 5) Reviewed-by: @gtxu before submission
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [X] Yes Claude Code (Sonnet 5)
Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
<!--
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix HttpAsyncHook crash on stream/cert/trust_env connection extras [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #71524:
URL: https://github.com/apache/airflow/pull/71524#issuecomment-5828669558
@gtxu Nice catch, if CI is green we can merge it, good work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix HttpAsyncHook crash on stream/cert/trust_env connection extras [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla merged PR #71524:
URL: https://github.com/apache/airflow/pull/71524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org