[jira] [Work logged] (HIVE-24991) Enable fetching deleted rows in vectorized mode

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24991?focusedWorklogId=607819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607819 ]

ASF GitHub Bot logged work on HIVE-24991:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/21 12:22
            Start Date: 07/Jun/21 12:22
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #2264:
URL: https://github.com/apache/hive/pull/2264#discussion_r646536788



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -1940,39 +2091,38 @@ public boolean isEmpty() {
     }
     @Override
     public void findDeletedRecords(ColumnVector[] cols, int size, BitSet selectedBitSet) {
-      if (rowIds == null || compressedOwids == null) {
+      if (rowIds == null || writeIds == null || writeIds.isEmpty()) {
         return;
       }
       // Iterate through the batch and for each (owid, rowid) in the batch
       // check if it is deleted or not.
 
       long[] originalWriteIdVector =
-          cols[OrcRecordUpdater.ORIGINAL_WRITEID].isRepeating ? null
-              : ((LongColumnVector) cols[OrcRecordUpdater.ORIGINAL_WRITEID]).vector;
+              cols[OrcRecordUpdater.ORIGINAL_WRITEID].isRepeating ? null

Review comment:
       Lets avoid changing the tabs/spaces below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 607819)
    Time Spent: 20m  (was: 10m)

> Enable fetching deleted rows in vectorized mode
> -----------------------------------------------
>
>                 Key: HIVE-24991
>                 URL: https://issues.apache.org/jira/browse/HIVE-24991
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>            Reporter: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> HIVE-24855 enables loading deleted rows from ORC tables when table property *acid.fetch.deleted.rows* is true.
> The goal of this jira is to enable this feature in vectorized orc batch reader.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)