You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2021/02/06 17:12:11 UTC

[httpcomponents-client] 01/02: Request message copy optimization

This is an automated email from the ASF dual-hosted git repository.

olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git

commit e6a7fe8a0cc6c1f4324b6078435ab6578746f6cf
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Sat Feb 6 17:36:24 2021 +0100

    Request message copy optimization
---
 .../main/java/org/apache/hc/client5/http/impl/RequestCopier.java    | 6 +++---
 .../apache/hc/client5/http/impl/classic/ClassicRequestCopier.java   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
index bb80d9f..0c90fbc 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
@@ -46,13 +46,13 @@ public final class RequestCopier implements MessageCopier<HttpRequest> {
         if (original == null) {
             return null;
         }
-        final BasicHttpRequest copy = new BasicHttpRequest(original.getMethod(), original.getPath());
+        final BasicHttpRequest copy = new BasicHttpRequest(original.getMethod(), null, original.getPath());
+        copy.setScheme(original.getScheme());
+        copy.setAuthority(original.getAuthority());
         copy.setVersion(original.getVersion());
         for (final Iterator<Header> it = original.headerIterator(); it.hasNext(); ) {
             copy.addHeader(it.next());
         }
-        copy.setScheme(original.getScheme());
-        copy.setAuthority(original.getAuthority());
         return copy;
     }
 
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
index 21e2db3..8621d1c 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
@@ -47,13 +47,13 @@ public final class ClassicRequestCopier implements MessageCopier<ClassicHttpRequ
         if (original == null) {
             return null;
         }
-        final BasicClassicHttpRequest copy = new BasicClassicHttpRequest(original.getMethod(), original.getPath());
+        final BasicClassicHttpRequest copy = new BasicClassicHttpRequest(original.getMethod(), null, original.getPath());
+        copy.setScheme(original.getScheme());
+        copy.setAuthority(original.getAuthority());
         copy.setVersion(original.getVersion());
         for (final Iterator<Header> it = original.headerIterator(); it.hasNext(); ) {
             copy.addHeader(it.next());
         }
-        copy.setScheme(original.getScheme());
-        copy.setAuthority(original.getAuthority());
         copy.setEntity(original.getEntity());
         return copy;
     }