[GitHub] [maven-build-cache-extension] michael-o commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #43:
URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1125469659


##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -597,4 +597,15 @@ private String getProperty(String key, String defaultValue) {
         }
         return value;
     }
+
+    private boolean getProperty(String key, boolean defaultValue) {
+        String value = session.getUserProperties().getProperty(key);
+        if (value == null) {
+            value = session.getSystemProperties().getProperty(key);
+            if (value == null) {
+                return defaultValue;
+            }
+        }
+        return Boolean.parseBoolean(value);

Review Comment:
   I think with system properties this is redundant, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org