You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kszucs (via GitHub)" <gi...@apache.org> on 2026/07/06 16:23:44 UTC
[PR] Add hf.revision property to pin HuggingFace Hub reads [iceberg-python]
kszucs opened a new pull request, #3609:
URL: https://github.com/apache/iceberg-python/pull/3609
# Rationale for this change
HuggingFace Hub (`hf://`) storage support already works via `fsspec`'s `HfFileSystem`, but has no way to pin reads to a specific revision (branch/tag/commit) for reproducibility, unlike iceberg-rust's `HF_REVISION`. `HfFileSystem` resolves `revision` per call rather than as a filesystem-wide default, so `hf.revision` is threaded through as a read-time kwarg on `FsspecInputFile`. Writes and deletes intentionally always target the repository's default branch, since a pinned revision can be an immutable tag or commit and isn't a valid write target.
## Are these changes tested?
Yes: unit tests covering revision forwarding on reads (`len()`, `.exists()`, `.open()`), confirming writes don't receive the revision kwarg, the no-revision-set default, and non-`hf` schemes being unaffected.
## Are there any user-facing changes?
Yes: new `hf.revision` table/catalog property, documented in `configuration.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: `hf.revision` property to pin HuggingFace Hub reads [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3609:
URL: https://github.com/apache/iceberg-python/pull/3609#issuecomment-5287926744
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: `hf.revision` property to pin HuggingFace Hub reads [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3609: fix: `hf.revision` property to pin HuggingFace Hub reads
URL: https://github.com/apache/iceberg-python/pull/3609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: `hf.revision` property to pin HuggingFace Hub reads [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3609:
URL: https://github.com/apache/iceberg-python/pull/3609#issuecomment-5199006644
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: `hf.revision` property to pin HuggingFace Hub reads [iceberg-python]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #3609:
URL: https://github.com/apache/iceberg-python/pull/3609#issuecomment-5491732548
Superseded by #3890 (rebased on current main, plus revision support for writes/deletes and precedence for revisions embedded in the location) — GitHub wouldn't let this one be reopened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org