You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/09/15 13:16:28 UTC
Review Request 62353: Added a master-registry backed resource provider
manager registry.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62353/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This patch adds an implementation of the resource provider registrar
backed by the master's registrar. With that it becomes possible to
persist resource provider manager state in a single master registrar,
but use the narrowly defined resource provider registry.
Diffs
-----
src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a
src/resource_provider/registrar.hpp PRE-CREATION
src/resource_provider/registrar.cpp PRE-CREATION
src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
Diff: https://reviews.apache.org/r/62353/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62353: Added a master-registry backed resource
provider manager registry.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62353/#review185509
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Sept. 15, 2017, 1:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62353/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 1:16 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an implementation of the resource provider registrar
> backed by the master's registrar. With that it becomes possible to
> persist resource provider manager state in a single master registrar,
> but use the narrowly defined resource provider registry.
>
>
> Diffs
> -----
>
> src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a
> src/resource_provider/registrar.hpp PRE-CREATION
> src/resource_provider/registrar.cpp PRE-CREATION
> src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
>
>
> Diff: https://reviews.apache.org/r/62353/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62353: Added a master-registry backed resource
provider manager registry.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62353/#review185483
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Sept. 15, 2017, 1:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62353/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 1:16 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an implementation of the resource provider registrar
> backed by the master's registrar. With that it becomes possible to
> persist resource provider manager state in a single master registrar,
> but use the narrowly defined resource provider registry.
>
>
> Diffs
> -----
>
> src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a
> src/resource_provider/registrar.hpp PRE-CREATION
> src/resource_provider/registrar.cpp PRE-CREATION
> src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77
>
>
> Diff: https://reviews.apache.org/r/62353/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>