You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by VinuL <gi...@git.apache.org> on 2015/08/27 15:11:09 UTC
[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...
GitHub user VinuL opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/32
Plugin returns network = none over Ethernet on Android
I tried to use Ethernet link to my Android tablet using this cable
http://www.amazon.co.uk/Smays-Micro-USB-Ethernet-Computer-Notebook/dp/B009XU6N54
I noticed my app returned Network = None.
So I added this little patch so the app now works over Ethernet link.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/VinuL/cordova-plugin-network-information master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 82fed3f0b53ebbd76ae77e20310c4e8ee9fa36f2
Author: VinuL <vi...@gmail.com>
Date: 2015-08-27T12:04:32Z
Update NetworkManager.java
I tried to use Ethernet link to my Android tablet using this cable
http://www.amazon.co.uk/Smays-Micro-USB-Ethernet-Computer-Notebook/dp/B009XU6N54
I noticed my app returned Network = None.
So I added this little patch so the app now works over Ethernet link.
commit 2eaa4daed4163960e0194687456069bea1743f1e
Author: VinuL <vi...@gmail.com>
Date: 2015-08-27T13:00:02Z
Merge pull request #1 from VinuL/VinuL-patch-1
Update NetworkManager.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/32#discussion_r38140684
--- Diff: src/android/NetworkManager.java ---
@@ -240,6 +241,9 @@ private String getType(NetworkInfo info) {
if (type.equals(WIFI)) {
return TYPE_WIFI;
}
+ else if (type.toLowerCase().equals(ETHERNET)) {
--- End diff --
Why add ETHERNET? Why not just:
`if (type.toLowerCase().equals(TYPE_ETHERNET)) { return TYPE_ETHERNET } `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...
Posted by VinuL <gi...@git.apache.org>.
Github user VinuL commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/32#issuecomment-135665148
Yes, good point! Sorted.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org