You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/08/03 10:02:20 UTC
[GitHub] [kylin] bigxiaochu opened a new pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
bigxiaochu opened a new pull request #1340:
URL: https://github.com/apache/kylin/pull/1340
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-669967593
It is a interesting patch from my side, I will do a test for this patch, thank you @bigxiaochu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-667962777
## Pull Request Test Coverage Report for [Build 6215](https://coveralls.io/builds/32499948)
* **5** of **13** **(38.46%)** changed or added relevant lines in **3** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.004%**) to **28.035%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java](https://coveralls.io/builds/32499948/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHiveCmdBuilder.java#L39) | 1 | 4 | 25.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java](https://coveralls.io/builds/32499948/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FBeelineHiveClient.java#L125) | 0 | 5 | 0.0%
<!-- | **Total:** | **5** | **13** | **38.46%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/32499948/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/32499948) |
| :-- | --: |
| Change from base [Build 6212](https://coveralls.io/builds/32477996): | 0.004% |
| Covered Lines: | 26235 |
| Relevant Lines: | 93579 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-669970663
But, generally speaking, your issues and pull requests did **NOT** provided enough backgroud, which is **NOT** a good practice for code reviewer and community, I wish you can provided more detail for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1340:
URL: https://github.com/apache/kylin/pull/1340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-692624279
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-669970663
But, generally speaking, you issue and pull request DID NOT provided enough backgroud, which is not a good practice for code reviewer and community's contributors, I wish you can provided more detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#discussion_r466443626
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java
##########
@@ -35,13 +35,22 @@
static final String CREATE_HQL_TMP_FILE_TEMPLATE = "cat >%s<<EOL\n%sEOL";
+ public static ThreadLocal<String> getHiveTablePrefix() {
+ return hiveTablePrefix;
+ }
+
+ public static void setHiveTablePrefix(ThreadLocal<String> hiveTablePrefix) {
Review comment:
Is it a useless method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] bigxiaochu commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix
Posted by GitBox <gi...@apache.org>.
bigxiaochu commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-680718484
@hit-lacus add content
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org