[GitHub] [dubbo-go] wangxw666 commented on a change in pull request #1405: Ftr: Added more event distribution types and improved event distribution mechanism for 1.5

[GitBox <gi...@apache.org>]

wangxw666 commented on a change in pull request #1405:
URL: https://github.com/apache/dubbo-go/pull/1405#discussion_r694460182



##########
File path: config/config_loader.go
##########
@@ -247,11 +257,22 @@ func loadProviderConfig() {
 		svs.id = key
 		svs.Implement(rpcService)
 		svs.Protocols = providerConfig.Protocols
-		if err := svs.Export(); err != nil {
-			panic(fmt.Sprintf("service %s export failed! err: %#v", key, err))
+		err := svs.Export()
+		serviceURL := svs.getValidURL()
+		if err != nil {
+			errMsg := fmt.Sprintf("service %s export failed! err: %#v", key, err)
+			svs.postProcessConfig(serviceURL, &map[string]string{

Review comment:
       为什么要把事件通知 耦合到URL中去？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org