You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rtudoran <gi...@git.apache.org> on 2016/01/06 14:45:13 UTC
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/1488
[FLINK-3167] Improve documentation for window apply
Small correction and extension for the window apply example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rtudoran/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1488
----
commit 0d986dda1cec697cf501839f5b0140c526741fb8
Author: rtudoran <tu...@ymail.com>
Date: 2016-01-06T13:02:41Z
[FLINK-3167] Improve documentation for window apply
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1488#issuecomment-169659515
Thank you for opening a pull request for fixing this.
I think its good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1488#issuecomment-169801392
Hi @rtudoran, I merged your PR.
No need to open another one for this issue :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1488#issuecomment-169703258
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by rtudoran <gi...@git.apache.org>.
GitHub user rtudoran reopened a pull request:
https://github.com/apache/flink/pull/1488
[FLINK-3167] Improve documentation for window apply
Small correction and extension for the window apply example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rtudoran/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1488
----
commit 0d986dda1cec697cf501839f5b0140c526741fb8
Author: rtudoran <tu...@ymail.com>
Date: 2016-01-06T13:02:41Z
[FLINK-3167] Improve documentation for window apply
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1488#issuecomment-169346238
it appears that you used the wrong issue ID; it should be 31**76** but is 31**67**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/1488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3167] Improve documentation for window ...
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the pull request:
https://github.com/apache/flink/pull/1488#issuecomment-169777353
Hi,
Should I do a re-commit and a pull request with the correct JIRA Number?
On Wednesday, 6 January 2016, 16:02, zentol <no...@github.com> wrote:
it appears that you used the wrong issue ID; it should be 3176 but is 3167.—
Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---